Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: axios error transformation on network errors #126

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

porcellus
Copy link
Collaborator

Summary of change

fix: axios error transformation on network errors

Related issues

  • Fixes: #5644

Test Plan

Added an extra test where we simulate a network error during a refresh call.

Documentation changes

N/A

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Copy link

github-actions bot commented Jun 13, 2024

size-limit report 📦

Path Size
lib/build/index.js 26.53 KB (+0.08% 🔺)

@rishabhpoddar rishabhpoddar merged commit 8d73989 into 5.1 Jun 15, 2024
4 checks passed
@rishabhpoddar rishabhpoddar deleted the fix/axios_error_transform branch June 15, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants